From b857b041ee73d24fefa2dce55d23e2ff97306af2 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 13 Feb 2017 15:20:55 +0100 Subject: [PATCH] x86emul: always init mmval ... to avoid buggy read/write sizes becoming info leaks. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- xen/arch/x86/x86_emulate/x86_emulate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index 270b5c6441..6cd9487291 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -2671,6 +2671,8 @@ x86_emulate( ea.reg = decode_register(modrm_rm, &_regs, (d & ByteOp) && !rex_prefix); + memset(mmvalp, 0xaa /* arbitrary */, sizeof(*mmvalp)); + /* Decode and fetch the source operand: register, memory or immediate. */ switch ( d & SrcMask ) { -- 2.30.2